-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StructuredMeshView as proxy between solver and actual StructuredMesh #1624
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
- Coverage 96.10% 96.09% -0.01%
==========================================
Files 451 453 +2
Lines 36414 36461 +47
==========================================
+ Hits 34993 35036 +43
- Misses 1421 1425 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…Trixi.jl into msl/structuredmesh-view
for different time steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final comments and suggestions, then this is good to merge imho. Thanks for pushing this forward!
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
since 'structured' is redundant for a file in this directory.
…amework/Trixi.jl into msl/structuredmesh-view
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@SimonCan LGTM! Can you do a review and approve this? It should then auto-merge once all tests have passed |
Codecov hiccups 😢 |
Added a new mesh type called
StructuredMeshView
. Rather than defining a new mesh they provide a view on a given parent mesh. They provide an extended set of functionalities compared to ordinary meshes and can be used in the same way. Their main application is in coupled simulations.