Node-level visualization support for coefficients of Subcell limiting #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bennibolm
commented
Aug 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
===========================================
+ Coverage 65.05% 84.28% +19.22%
===========================================
Files 419 419
Lines 34118 34176 +58
===========================================
+ Hits 22194 28802 +6608
+ Misses 11924 5374 -6550
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bennibolm
changed the title
23 tasks
efaulhaber
requested changes
Sep 5, 2023
efaulhaber
requested changes
Sep 5, 2023
efaulhaber
approved these changes
Sep 6, 2023
|
@bennibolm I was overexcited when I approved the PR and thus had forgotten about some comments I added earlier. If those have been resolved (which shouldn't be hard), this is good to go! |
sloede
requested changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the handling with node-level data as the subcell limiting blending factors. In combination with the PR to Trixi2Vtk.jl, this allows the visualization of those coefficients.