Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Flux to 0.14 for package test, (keep existing compat) #1568

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Flux package from 0.13 - 0.13.12 to 0.13 - 0.13.12, 0.14 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2023-07-15-00-08-54-752-04130216448 branch from 00d9d77 to d59cab2 Compare July 15, 2023 00:09
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #1568 (d59cab2) into main (905c8e2) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
- Coverage   91.96%   91.84%   -0.12%     
==========================================
  Files         383      383              
  Lines       31958    31935      -23     
==========================================
- Hits        29388    29328      -60     
- Misses       2570     2607      +37     
Flag Coverage Δ
unittests 91.84% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 83 files with indirect coverage changes

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not now: #1368

@sloede
Copy link
Member

sloede commented Feb 5, 2024

Obsolete with #1701, #1705

@sloede sloede closed this Feb 5, 2024
@sloede sloede deleted the compathelper/new_version/2023-07-15-00-08-54-752-04130216448 branch February 5, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants