Add Dirichlet BCs for Navier-Stokes primitive variables #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
…p4est_parabolic_BCs
Codecov Report
@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 96.04% 96.05% +0.01%
==========================================
Files 368 369 +1
Lines 31049 31116 +67
==========================================
+ Hits 29821 29888 +67
Misses 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jlchan
requested changes
Jun 23, 2023
There was a problem hiding this comment.
This PR should have shrunk after merging #1493, but it didn't seem to do so. @apey236, can you create a fresh branch off of main (following https://trixi-framework.github.io/Trixi.jl/dev/github-git/#Create-a-branch-and-*immediately*-create-a-pull-request) and submit a new PR with these changes?
It should just be the Dirichlet BC changes to the 3 files
- elixir_navierstokes_convergence_nonperiodic.jl
- compressible_navier_stokes_2d.jl
- test_parabolic_2d.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of Dirichlet BCs for the Navier-Stokes parabolic terms with primitive gradient variables.
This builds off of #1493, which should be merged first.