-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify DGMultiMesh
constructor signature, update overview.md
#1386
Unify DGMultiMesh
constructor signature, update overview.md
#1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did you check that the deprecation works as expected?
Not yet - let me convert this to draft, I don't think it's quite ready. |
The deprecation does seem to work. Tests were failing for some other reasons, those should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Seems like some tests are failing due to the elixirs triggering a deprecation warning and Content of `stderr`:
[ Info: You just called `trixi_include`. Julia may now compile the code, please be patient.
┌ Warning: `DGMultiMesh(dg::DGMulti{NDIMS}; cells_per_dimension, kwargs...) where NDIMS` is deprecated, use `DGMultiMesh(dg, cells_per_dimension; kwargs...)` instead.
│ caller = ip:0x0
└ @ Core :-1
elixir_euler_weakform_periodic.jl: Test Failed at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:167
Expression: occursin(r"^(WARNING: replacing module .+\.\n)*$", stderr_content)
Evaluated: occursin(r"^(WARNING: replacing module .+\.\n)*$", "┌ Warning: `DGMultiMesh(dg::DGMulti{NDIMS}; cells_per_dimension, kwargs...) where NDIMS` is deprecated, use `DGMultiMesh(dg, cells_per_dimension; kwargs...)` instead.\n│ caller = ip:0x0\n└ @ Core :-1\n")
Stacktrace:
[1] macro expansion
@ /opt/hostedtoolcache/julia/1.8.5/x64/share/julia/stdlib/v1.8/Test/src/Test.jl:464 [inlined]
[2] macro expansion
@ ~/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:167 [inlined]
[3] macro expansion
@ ~/work/Trixi.jl/Trixi.jl/test/test_dgmulti_2d.jl:124 [inlined]
[4] macro expansion
@ /opt/hostedtoolcache/julia/1.8.5/x64/share/julia/stdlib/v1.8/Test/src/Test.jl:1363 [inlined]
[5] top-level scope
@ ~/work/Trixi.jl/Trixi.jl/test/test_dgmulti_2d.jl:124 I replaced all the example and Literate elixirs with the new constructor. Hopefully it helps |
Codecov Report
@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
+ Coverage 86.99% 93.69% +6.70%
==========================================
Files 344 344
Lines 28526 28560 +34
==========================================
+ Hits 24816 26758 +1942
+ Misses 3710 1802 -1908
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 122 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@ranocha I added a |
It is not breaking if the constructor is just deprecated but still works |
But we should mention it in NEWS.md |
Agreed; added a note in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Addresses part of #1194.
This would be a breaking change (introduces a new deprecation).