Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERK p2 #1871

Closed
wants to merge 76 commits into from
Closed

PERK p2 #1871

wants to merge 76 commits into from

Conversation

warisa-r
Copy link
Contributor

Hello,

this branch adds a new time integrator of second-order paired explicit Runge-Kutta method.
It contains the time integrator, a polynomial optimizer for the method, and a new elixir employing the second-order P-ERK time integration scheme with 6 stages.

DanielDoehring and others added 30 commits January 29, 2024 10:06
Co-authored-by: Daniel Doehring <[email protected]>
@DanielDoehring DanielDoehring added the enhancement New feature or request label Mar 15, 2024
@DanielDoehring DanielDoehring self-assigned this Mar 15, 2024
@DanielDoehring
Copy link
Contributor

DanielDoehring commented Mar 17, 2024

For some reason the SummaryCallback causes the allocations causing the test to fail.

This is observed also for the other custom integrators, see

@trixi_testset "elixir_advection_timeintegration.jl" begin
@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_timeintegration.jl"),
l2=[2.4976030518356626e-5],
linf=[0.0005531580316338533],
# Let this test terminate by time instead of maxiters to cover some lines
# in time_integration/methods_2N.jl
coverage_override=(maxiters = 10^5, tspan = (0.0, 0.1)))
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
t = sol.t[end]
u_ode = sol.u[end]
du_ode = similar(u_ode)
@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 15000

and the other tests.

@DanielDoehring
Copy link
Contributor

DanielDoehring commented Mar 18, 2024

Not sure if I can add a version for DelimitedFiles as I get for DelimitedFiles = "1.9.0"

  ERROR: LoadError: Unsatisfiable requirements detected for package DelimitedFiles [8bb1440f]:
 DelimitedFiles [8bb1440f] log:
 ├─possible versions are: 1.9.0-1.9.1 or uninstalled
 └─restricted to versions 1.8.5-1.8 by Trixi [a7f1ee26] — no versions lef

and for DelimitedFiles=1.8.5 (for which no release seems to exist)

 ERROR: LoadError: Unsatisfiable requirements detected for package DelimitedFiles [8bb1440f]:
DelimitedFiles [8bb1440f] log:
├─possible versions are: 1.8.5 or uninstalled (package in sysimage!)
└─restricted to versions 1.9.0-1 by Trixi [a7f1ee26] — no versions left

@JoshuaLampert

@JoshuaLampert
Copy link
Member

Yes, for the Downgrade action that's to be expected as DelimitedFiles is a stdlib. It should be added to the list of skipped libraries. The compat could then be DelimitedFiles = "1.9.0". You could also try DelimitedFiles = "1".

@JoshuaLampert
Copy link
Member

@DanielDoehring
Copy link
Contributor

You could also try DelimitedFiles = "1".

That seems to work, thanks!

@DanielDoehring DanielDoehring marked this pull request as draft March 27, 2024 15:29
@warisa-r
Copy link
Contributor Author

Close this one for now. Working on making Convex and ECOS extensions rather than direct dependencies.

@warisa-r warisa-r closed this Apr 17, 2024
@warisa-r warisa-r mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants