Skip to content

Commit

Permalink
Deprecate some DGMultiMesh constructors (#1709)
Browse files Browse the repository at this point in the history
* remove previously deprecated functions

* fix typo in NEWS.md about deprecation vs removal

* fix literate tutorial

* removing other deprecation

* format

* Revert "fix typo in NEWS.md about deprecation vs removal"

This reverts commit 6b03020.
  • Loading branch information
jlchan authored and ranocha committed Nov 11, 2023
1 parent 6eb0b5b commit b860e65
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion docs/literate/src/files/DGMulti_1.jl
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ meshIO = StartUpDG.triangulate_domain(StartUpDG.RectangularDomainWithHole());

# The pre-defined Triangulate geometry in StartUpDG has integer boundary tags. With [`DGMultiMesh`](@ref)
# we assign boundary faces based on these integer boundary tags and create a mesh compatible with Trixi.jl.
mesh = DGMultiMesh(meshIO, dg, Dict(:outer_boundary=>1, :inner_boundary=>2))
mesh = DGMultiMesh(dg, meshIO, Dict(:outer_boundary=>1, :inner_boundary=>2))
#-
boundary_condition_convergence_test = BoundaryConditionDirichlet(initial_condition)
boundary_conditions = (; :outer_boundary => boundary_condition_convergence_test,
Expand Down
12 changes: 0 additions & 12 deletions src/solvers/dgmulti/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -433,15 +433,3 @@ function LinearAlgebra.mul!(b_in, A_kronecker::SimpleKronecker{3}, x_in)
return nothing
end
end # @muladd

# TODO: deprecations introduced in Trixi.jl v0.6
@deprecate DGMultiMesh(dg::DGMulti{NDIMS}; cells_per_dimension, kwargs...) where {NDIMS} DGMultiMesh(dg,
cells_per_dimension;
kwargs...)

# TODO: deprecations introduced in Trixi.jl v0.5
@deprecate DGMultiMesh(vertex_coordinates, EToV, dg::DGMulti{NDIMS};
kwargs...) where {NDIMS} DGMultiMesh(dg, vertex_coordinates, EToV;
kwargs...)
@deprecate DGMultiMesh(triangulateIO, dg::DGMulti{2, Tri}, boundary_dict::Dict{Symbol, Int};
kwargs...) DGMultiMesh(dg, triangulateIO, boundary_dict; kwargs...)

0 comments on commit b860e65

Please sign in to comment.