Update HOHQMeshMain.f90 #121
Conversation
Add help to be printed with the -help option.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 75.05% 75.83% +0.77%
==========================================
Files 68 68
Lines 10519 10568 +49
Branches 2 2
==========================================
+ Hits 7895 8014 +119
+ Misses 2624 2554 -70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Source/HOHQMeshMain.f90
Outdated
| WRITE(OUTPUT_UNIT,*) "Invocation:" | ||
| WRITE(OUTPUT_UNIT,*) " ./HOHQMesh [options]" | ||
| WRITE(OUTPUT_UNIT,*) "Options:" | ||
| WRITE(OUTPUT_UNIT,*) "-help" |
There was a problem hiding this comment.
| WRITE(OUTPUT_UNIT,*) "-help" | |
| WRITE(OUTPUT_UNIT,*) "-help or --help" |
For consistency if both commands are allowed.
There was a problem hiding this comment.
best is to also check if all command line arguments could be associated, and if not, print the help instead.
so if someone would now type -h, which is not part of the possible arguments, then the help would still appear.
From the argument syntax, I am more used to a minus with one letter, like -f followed by space and value, or an equivalent long argument like --file followed by = and value.
All this functionality would be provided by CLAF90, you should give it a try...
There was a problem hiding this comment.
A couple of issues with CLAF90, though. 1. No license. 2. We then depend on them maintaining it. I have been burned too many times over the years by libraries that stop being maintained and hence avoid them.
There was a problem hiding this comment.
well the license says that you can copy it, so I just copied it into my code, its not something that need maintenance. But no worries, its your choice ;)
Now accepts -h, -help, --help for help. Prints out help when there is an error in the command line arguments.
|
OK, I've added three options to get help: -help, --help and -h. The help message gets printed if there is an error. |
|
I still need to put in some test coverage. Will do that next. |
Remove -h option. Add comment that partial command line aregumens are handled.
Add a MiscTests procedure to put in miscellaneous tests from now on. Right now, it calls the PrintHelpMessage procedure to scratch to include covereage.
|
It passes codecov/project but not codecov/patch. Not sure what that means, and I'm not sure how to test command line arguments when those are passed through from the user. Unless there is some way to spoof the CLAs. |
|
I improved coverage in cddf7f7. LGTM now! |
Add help to be printed with the -help option.