Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support importOrderImportAttributesKeyword #273

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

chentsulin
Copy link

@chentsulin chentsulin commented Dec 12, 2023

Fix #270.
Add an importOrderImportAttributesKeyword option to support three different kinds of syntax.

For example:

  "importOrderImportAttributesKeyword": 'with'

Todo:

* "importOrderImportAttributesKeyword": 'with',
* ```
*
* _Default behavior:_ When not specified, @babel/generator will try to match the style in the input code based on the AST shape.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you find this default behavior not to be reliable enough?

@byara byara requested review from ayusharma and byara December 3, 2024 14:48
@byara byara changed the base branch from main to v5 December 3, 2024 14:48
@byara byara force-pushed the feat/support-import-attributes branch from 6c9e134 to b83e56a Compare December 3, 2024 17:00
@byara byara merged commit 3341a50 into trivago:v5 Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package breaks when using import assertions
3 participants