Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velocity): @version@ placeholder not being replaced in VelocityTriton #459

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Nov 13, 2024

Since this class is now inside a jar-in-jar, blossom does not replace the @version@ placeholder.
The proper fix is to get it from the plugin container instead of having the placeholders in two different places.

Fixes #434

…iton

Since this class is now inside a jar-in-jar, blossom does not replace
the @Version@ placeholder.
The proper fix is to get it from the plugin container instead of having
the placeholders in two different places.

Fixes #434
@diogotcorreia diogotcorreia added type:bug Something isn't working as expected module:velocity Related to Velocity labels Nov 13, 2024
@diogotcorreia diogotcorreia added this to the 4.0.0 milestone Nov 13, 2024
@diogotcorreia diogotcorreia self-assigned this Nov 13, 2024
@diogotcorreia diogotcorreia merged commit b515c7a into v4 Nov 13, 2024
1 check passed
@diogotcorreia diogotcorreia deleted the fix-version-placeholder-velocity branch November 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:velocity Related to Velocity type:bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant