chore(deps): update dependency requests to v2.31.0 [security] #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
===========================================
+ Coverage 0 19.31% +19.31%
- Complexity 0 33 +33
===========================================
Files 0 73 +73
Lines 0 15096 +15096
Branches 0 1897 +1897
===========================================
+ Hits 0 2916 +2916
- Misses 0 11872 +11872
- Partials 0 308 +308 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Mewmba <[email protected]>
Co-authored-by: Mewmba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==2.28.1->==2.31.0GitHub Vulnerability Alerts
CVE-2023-32681
Impact
Since Requests v2.3.0, Requests has been vulnerable to potentially leaking
Proxy-Authorizationheaders to destination servers, specifically during redirects to an HTTPS origin. This is a product of howrebuild_proxiesis used to recompute and reattach theProxy-Authorizationheader to requests when redirected. Note this behavior has only been observed to affect proxied requests when credentials are supplied in the URL user information component (e.g.https://username:password@proxy:8080).Current vulnerable behavior(s):
For HTTP connections sent through the proxy, the proxy will identify the header in the request itself and remove it prior to forwarding to the destination server. However when sent over HTTPS, the
Proxy-Authorizationheader must be sent in the CONNECT request as the proxy has no visibility into further tunneled requests. This results in Requests forwarding the header to the destination server unintentionally, allowing a malicious actor to potentially exfiltrate those credentials.The reason this currently works for HTTPS connections in Requests is the
Proxy-Authorizationheader is also handled by urllib3 with our usage of the ProxyManager in adapters.py withproxy_manager_for. This will compute the required proxy headers inproxy_headersand pass them to the Proxy Manager, avoiding attaching them directly to the Request object. This will be our preferred option going forward for default usage.Patches
Starting in Requests v2.31.0, Requests will no longer attach this header to redirects with an HTTPS destination. This should have no negative impacts on the default behavior of the library as the proxy credentials are already properly being handled by urllib3's ProxyManager.
For users with custom adapters, this may be potentially breaking if you were already working around this behavior. The previous functionality of
rebuild_proxiesdoesn't make sense in any case, so we would encourage any users impacted to migrate any handling of Proxy-Authorization directly into their custom adapter.Workarounds
For users who are not able to update Requests immediately, there is one potential workaround.
You may disable redirects by setting
allow_redirectstoFalseon all calls through Requests top-level APIs. Note that if you're currently relying on redirect behaviors, you will need to capture the 3xx response codes and ensure a new request is made to the redirect destination.Credits
This vulnerability was discovered and disclosed by the following individuals.
Dennis Brinkrolf, Haxolot (https://haxolot.com/)
Tobias Funke, (tobiasfunke93@gmail.com)
Release Notes
psf/requests (requests)
v2.31.0Compare Source
Security
Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential
forwarding of
Proxy-Authorizationheaders to destination servers whenfollowing HTTPS redirects.
When proxies are defined with user info (https://user:pass@proxy:8080), Requests
will construct a
Proxy-Authorizationheader that is attached to the request toauthenticate with the proxy.
In cases where Requests receives a redirect response, it previously reattached
the
Proxy-Authorizationheader incorrectly, resulting in the value beingsent through the tunneled connection to the destination server. Users who rely on
defining their proxy credentials in the URL are strongly encouraged to upgrade
to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy
credentials once the change has been fully deployed.
Users who do not use a proxy or do not supply their proxy credentials through
the user information portion of their proxy URL are not subject to this
vulnerability.
Full details can be read in our Github Security Advisory
and CVE-2023-32681.
v2.30.0Compare Source
Dependencies
This may contain minor breaking changes so we advise careful testing and
reviewing https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
prior to upgrading.
Users who wish to stay on urllib3 1.x can pin to
urllib3<2.v2.29.0Compare Source
Improvements
standardization. (#6226)
v2.28.2Compare Source
Dependencies
Bugfixes
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.
PR-Codex overview
This PR focuses on updating various dependencies and generated code.
Detailed summary
requestslibrary from version 2.28.1 to 2.31.0 in bothdevops/requirements.txtandpython/requirements.txt.grpcio-toolslibrary from version 1.28.1 to 1.31.0 indevops/requirements.txt.PyYAMLlibrary from version 5.4.1 to 6.0 indevops/requirements.txt.gql[all]library from version 3.3.0 to 3.4.0 indevops/requirements.txt.python-dateutillibrary from version 2.8.1 to 2.8.2 indevops/requirements.txt.grpcliblibrary from version 0.4.2 to 0.4.3 inpython/requirements.txt.protoc-gen-goto 1.31.0 in multiple Go files.protocto 3.20.3 in multiple Go files.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.pyGenericServicestotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHashtotrueindart/lib/proto/google/protobuf/descriptor.pb.dart.javaGenerateEqualsAndHash