Fix boolean value return [Android]

#68 Fixes enable/disable debug mode
triniwiz · Sep 18, 2018 · c8cac5e · c8cac5e
1 parent 8957ac2
commit c8cac5e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/package.json b/src/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "nativescript-socketio",
-	"version": "3.1.4",
+	"version": "3.1.5",
 	"description": "Socket.IO for nativescript",
 	"main": "socketio",
 	"typings": "index.d.ts",

diff --git a/src/socketio.android.ts b/src/socketio.android.ts
@@ -30,7 +30,7 @@ export class SocketIO extends Common {
                         } else if (typeof query === 'string') {
                             opts.query = query;
                         }
-                    } else if (key === 'debug') {
+                    } else if (key === 'debug' && options[key]) {
                         co.fitcom.fancylogger.FancyLogger.reset(new co.fitcom.fancylogger.FancyLogger());
 
                         java.util.logging.Logger.getLogger(io.socket.client.Socket.class.getName()).setLevel(java.util.logging.Level.FINEST);
@@ -217,7 +217,7 @@ export function deserialize(data): any {
         }
 
         case 'java.lang.Boolean': {
-            return Boolean(data);
+            return String(data) === 'true';
         }
 
         case 'java.lang.Integer':

diff --git a/src/socketio.ios.ts b/src/socketio.ios.ts
@@ -60,7 +60,7 @@ export class SocketIO extends Common {
                             Object.assign(connectParams, optionsQuery);
 
                         }
-                    } else if (key === 'debug') {
+                    } else if (key === 'debug' && obj[key]) {
                         opts['log'] = true;
                     } else {
                         opts[key] = serialize(obj[key]);