Fix crash when saving generated files for NXT #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinyazevR
changed the title
MinyazevR
force-pushed
the
MinyazevR-fix-nxt-generation-crash
branch
from
0f48541 to
ea22f09
Compare
iakov
changed the title
iakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to save the source file generated for
NXT,TRIKStudiocrashes withuse heap after free.This solution is a crutch, as you need to give ownership of
NxtOsekCMasterGeneratorto theNxtOsekCGeneratorPluginclass, but you will have to rewrite RobotsGeneratorPluginBase (which will lead to changes in behavior in others KITs)