Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo: respect --login regardless of the presence of --chdir #794

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Oct 26, 2023

closes #793

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5cf4857) 55.38% compared to head (7c1c0ca) 55.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   55.38%   55.34%   -0.04%     
==========================================
  Files          72       72              
  Lines        9833     9831       -2     
==========================================
- Hits         5446     5441       -5     
- Misses       4387     4390       +3     
Files Coverage Δ
src/common/command.rs 91.72% <100.00%> (-0.17%) ⬇️
src/exec/mod.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@japaric japaric added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 724ed34 Nov 2, 2023
15 checks passed
@japaric japaric deleted the fix-chdir-login branch November 3, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--login not respected when used with --chdir
2 participants