Reuse session when running kcadm commands #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
kcadm-config
branch
3 times, most recently
from
e9bad60 to
c27b4cb
Compare
…pt and not a template
treydock
force-pushed
the
kcadm-config
branch
from
c27b4cb to
e7e2a3b
Compare
nblock
reviewed
Nov 18, 2024
files/kcadm-wrapper.sh
Outdated
| EXPIRES=$(/usr/bin/sed -n -r 's|.*"refreshExpiresAt" : ([0-9]*).*|\1|p' "$CONFIG" || echo "0") | ||
| NOW=$(/usr/bin/date +%s%3N) | ||
|
|
||
| if [ ! -f "$CONFIG" ] || [ "$EXPIRES" -gt "$NOW" ]; then |
There was a problem hiding this comment.
This should be: if [ ! -f "$CONFIG" ] || [ "$EXPIRES" -lt "$NOW" ]; then otherwise a full login is performed with each invocation.
There was a problem hiding this comment.
Thanks for catching that, I've updated. Hoping to test locally sometime today with some extra logging in a branch to fully validate this new logic.
…ng persistent sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327