feat: add many to many connections #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables many-to-manny graphs by extending input ports with a capability to optionally accept multiple connections, via a max_connections parameter. If this parameter is set to anything other than Some(NonZeroU32(1)) the port will be referred to as `wide`. * Adjust Graph::connections to map from InputId to Vec<OutputId> instead of just OutputId. * Adjust UI to render wide ports as segments extending in length proportionally to the number of connections. * Allow creating a new connection by dragging from an extra slot in a wide port. * If a wide port is not full, an in-progress connection will move existing ones out of the way to allow intuitive ordering. Otherwise, the new connection will override the one it's hovering over within the port. * Extend NodeResponse::ConnectEventEnded with an additional field containing the index under which the new connection resides within the input port. * Add Graph::add_wide_input_param for creating wide ports.
…many-to-many Co-Authored-By: Kamil Koczurek <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports this PR from the original
egui_node_graphto work with this fork. As mentioned in the original PR, the functionality looks good. I tested briefly and no issues were found