-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml with hatch #156
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 91.37% 97.37% +5.99%
==========================================
Files 31 16 -15
Lines 2493 1484 -1009
Branches 0 209 +209
==========================================
- Hits 2278 1445 -833
+ Misses 215 26 -189
- Partials 0 13 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I modified a bit the Github action so instead of calling hatch once to run all the tests, the workflow creates a matrix of python and seaborn versions (we could also add an OS matrix if needed, see https://github.com/platformdirs/platformdirs/ for the modifications to do). Github runs matrix jobs in parallel so the tests are substantially faster. |
I forgot to mention that python 3.7 is not tested (hatch was not working for me with this python version). It would be better to drop it, as it is EOL anyway. |
use hatch environments add test_script to test plotting figures
Thanks for merging #155, I rebased this PR, all tests are passing now. I will check the jupyter notebook. Reminder: minimal python version is set to 3.8 |
The notebook runs correctly with python 3.12. I added support for python 3.13 (only compatible with seaborn 0.13), the tests are passing. |
Coverage is working now! |
@trevismd it's ready for review |
@@ -9,15 +9,14 @@ name = "statannotations" | |||
description = "add statistical significance or custom annotations on seaborn plots. Based on statannot 0.2.3" | |||
readme = "README.md" | |||
license = {text = "MIT License"} | |||
requires-python = ">=3.7" | |||
requires-python = ">=3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah forgot about this one... Do you mind if I cherry-pick this one independently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure!
If you are planning a patch release, I realized the README also needs minor corrections: mention that the last version is 0.6, should be 0.7.
closes #150 I moved all the source files to a Also I added some linting scripts: |
Modernize the building and testing framework:
add test_script to test plotting figures-> added in Compatibility with seaborn 0.13 #155To build:
hatch build
orpython -m build
To bump version:
hatch version minor
To test:
hatch run tests:run
To test with coverage:
hatch run tests:run-cov && hatch run coverage:run
To build and test docs:
hatch run docs:all
To run examples:
hatch run examples:run -- --plot_type=boxplot --data_type=df_with_group_and_hue
To test #155 I had to write the
test_script.py
file and it was very convenient to usehatch
environments for testing. So I thought I should actually make a PR about it :)