Remove cookieconsent js from Docs #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
|
♻️ PR Preview a5e4758 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
N-o-Z
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8440.
Change Description
Background
The API page of the lakeFS Docs loads for the first time,
But after accepting the cookies consent ("Hello fellow axolotl, it's cookie time!"), the Swagger part of the page fails to load.
This happens due to the "cookieconsent-init.js". Once it's removed, the page loads fine.
Bug Fix
Since we already have a cookies-consent popup provided by HubSpot, the fix is to simply remove the "cookieconsent-init.js" from the docs.
Testing Details
Tested in the CI.