Add Pull Requests to docs #8376
Conversation
itaigilo
added
the
include-changelog
|
♻️ PR Preview fa1dc38 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| - /reference/pull_requests.html | ||
| --- | ||
|
|
||
| # Pull Requests |
There was a problem hiding this comment.
Can you please add an RBAC section?
There was a problem hiding this comment.
AFAIK (maybe @N-o-Z will know better), this feature is currently available to all users.
Plus, if an admin will change the RBAC conf for PRfD, the tab (and "Create PR" button) will still show up for users, but yield errors when trying to act -
So maybe it's better to leave RBAC out of this doc until it's more mature?
There was a problem hiding this comment.
The RBAC section (permissions) is under the RBAC page. We can link to it, but how is this different from any other feature that requires permissions?
There was a problem hiding this comment.
Some have it (e.g. morroring) but we're inconsistent. A valid point, we can go ahead without it because it is easy to understand from RBAC page.
idanovo
added
exclude-changelog
Closes #8293.
Change Description
Adding Pull Requests to the docs (in the "How To" section).
This blog post was used as a reference.