Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the required query parameter for SCIM with Entra ID #8218

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Sep 24, 2024

No description provided.

Copy link

github-actions bot commented Sep 24, 2024

♻️ PR Preview e842151 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@guy-har guy-har added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

E2E Test Results - Quickstart

11 passed

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -74,7 +74,7 @@ To set up your IdP, you'll need the lakeFS Cloud SCIM provisioning endpoint and
In the Entra ID admin dashboard, go to **Enterprise Applications** and choose the lakeFS Cloud enterprise application from the list. Then click **Provisioning** in the sidebar and then **Get Started**.

1. In the provisioning settings set mode to **Automatic**
2. In **Tenant URL** enter the URL from the lakeFS Cloud provisioning settings
2. In **Tenant URL** enter the URL from the lakeFS Cloud provisioning settings. You will need to append `?aadOptscim062020` to the end of the URL to ensure proper integration with Entra ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea to open an issue to remove this in a couple of months when this becomes the default

@@ -74,7 +74,7 @@ To set up your IdP, you'll need the lakeFS Cloud SCIM provisioning endpoint and
In the Entra ID admin dashboard, go to **Enterprise Applications** and choose the lakeFS Cloud enterprise application from the list. Then click **Provisioning** in the sidebar and then **Get Started**.

1. In the provisioning settings set mode to **Automatic**
2. In **Tenant URL** enter the URL from the lakeFS Cloud provisioning settings
2. In **Tenant URL** enter the URL from the lakeFS Cloud provisioning settings. You will need to append `?aadOptscim062020` to the end of the URL to ensure proper integration with Entra ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Maybe document what happens if this isn't appended?

@guy-har guy-har force-pushed the docs/scim-entra-url branch from 7e3a345 to e842151 Compare December 29, 2024 10:57
@guy-har guy-har merged commit e3b46c1 into master Dec 29, 2024
39 checks passed
@guy-har guy-har deleted the docs/scim-entra-url branch December 29, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants