branch now can't merge to itself #8149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
requested changes
Sep 10, 2024
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7824
Change Description
Disabling the option of merging a branch to itself.
Background
After introducing the new flags
--allow-empty&--force, users had the option of merging a branch to itself.This modification blocks this option by checking whether the branches source and destination are equal.
Testing Details
Manually, did not create a dedicated test
Additional info
For the error, I used the already exist
ErrNoChangeserror and did not create a new one.Contact Details
[email protected]