Serve GZipped Static Assets #7788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladlachmi
added
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
arielshaqed
approved these changes
May 21, 2024
| @@ -33,7 +34,8 @@ func NewUIHandler(gatewayDomains []string, snippets []params.CodeSnippet) http.H | |||
| panic(err) | |||
| } | |||
| fileSystem := http.FS(injectedContent) | |||
| etagHandler := EtagMiddleware(injectedContent, http.StripPrefix("/", http.FileServer(fileSystem))) | |||
| gzipHandler := gziphandler.GzipHandler(http.FileServer(fileSystem)) | |||
There was a problem hiding this comment.
Not sure that I understand. We are serving just a few bundles, they are statically embedded into the executable. Can we hold the precompress the bundled objects and serve them directly but compressed? (Does any browser from the past 10 years not support this?)
There was a problem hiding this comment.
You're not wrong. However, it's unusual to store GZipped assets on disk. GZipping the response is usually the responsibility of some reverse proxy in front of the asset server (e.g., nginx, Varnish, or something like CloudFront.)
I'll concede that most reasons for doing this aren't relevant to our use case. However, I decided to go this route under these assumptions:
- Low complexity
- Static assets can be cached client side and we can expect a low request rate in regular use
- The Go impl. isn't as efficient as the one used by nginx (C-based), but not far from it and we're using the default level, so this isn't expected to create any noticeable additional compute load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added a Gzip handler to gzip files served by the embedded filesystem handler. This results in a ~63% reduction in transferred bytes.
Before:
After: