Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dockerfile cross compile #7286

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Fix dockerfile cross compile #7286

merged 4 commits into from
Jan 15, 2024

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Jan 15, 2024 •
edited
Loading

  • Removed build and publish for darwin arm64/amd64 as alpine doesn't have it as base image.
  • Fix cross compile docker image to work on arm based machines - the host OS requires a fix.
  • Reduce image size by removing delta plugins
  • Reduce build time by parallel steps - base for lakectl and lakefs

Test working using by docker lakefs experiment image, running lakefs and sh from image on:

  • ec2 arm64 instance
  • ec2 amd64 instance
  • local macbook pro M2

Fix: #7257

@nopcoder nopcoder self-assigned this Jan 15, 2024
@nopcoder nopcoder added infrastructure build, deploy and release processes include-changelog PR description should be included in next release changelog labels Jan 15, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

@nopcoder nopcoder requested a review from a team January 15, 2024 08:31
@nopcoder nopcoder requested a review from itaiad200 January 15, 2024 12:06
Jonathan-Rosenberg
Jonathan-Rosenberg approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nopcoder nopcoder merged commit 5a4003e into master Jan 15, 2024
36 checks passed
@nopcoder nopcoder deleted the fix/docker-cross-compile branch January 15, 2024 12:18
@nopcoder nopcoder removed the request for review from itaiad200 January 15, 2024 12:18
nopcoder added a commit that referenced this pull request Jan 17, 2024
@nopcoder
Fix dockerfile cross compile (#7286)
2156b9c 
* dockerfile fix cross compile and reduce size

* limit platforms to linux amd64 and arm64

* remove darwin{amd64,arm64} as alpine base doesn't have one

* Fix apps in path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonathan-Rosenberg Jonathan-Rosenberg Jonathan-Rosenberg approved these changes

Assignees

@nopcoder nopcoder

Labels
include-changelog PR description should be included in next release changelog infrastructure build, deploy and release processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Linux system binaries are failing with arm64 docker images
2 participants
@nopcoder @Jonathan-Rosenberg