UI Etag support for embedded content #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scan embedded content on startup and serve etag header to FileServer. FileServer will use the Etag and provide no content change if needed. This will allow cache all static resources, which allow better performance after the first load, in the web ui.
nopcoder
added
the
include-changelog
N-o-Z
requested changes
Dec 9, 2023
pkg/api/ui_handler.go
Outdated
| @@ -34,7 +33,7 @@ func NewUIHandler(gatewayDomains []string, snippets []params.CodeSnippet) http.H | |||
| panic(err) | |||
| } | |||
| fileSystem := http.FS(injectedContent) | |||
| nocacheContent := middleware.NoCache(http.StripPrefix("/", http.FileServer(fileSystem))) | |||
| nocacheContent := EtagMiddleware(injectedContent, http.StripPrefix("/", http.FileServer(fileSystem))) | |||
There was a problem hiding this comment.
Thanks - I missed that
pkg/api/etag_middleware.go
Outdated
| } | ||
| defer func() { _ = f.Close() }() | ||
|
|
||
| h := md5.New() |
There was a problem hiding this comment.
Checking if crc32 will do a better work here
pkg/api/etag_middleware.go
Outdated
| package api | ||
|
|
||
| import ( | ||
| "crypto/md5" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan embedded content on startup and serve etag header to FileServer. FileServer will use the Etag and provide no content change if needed.
This will allow cache all static resources, which allow better performance after the first load, in the web ui.
Close #7131