Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support upload object without content type #7130

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: support upload object without content type #7130

merged 1 commit into from
Dec 8, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 8, 2023

Default to use "application/octet-stream" content type

Close #7127

@nopcoder
fix: support upload object without content type
6e6e041 
default to use "application/octet-stream" content type
@nopcoder nopcoder requested a review from a team December 8, 2023 15:30
@nopcoder nopcoder self-assigned this Dec 8, 2023
@nopcoder nopcoder added bug Something isn't working include-changelog PR description should be included in next release changelog labels Dec 8, 2023
N-o-Z
N-o-Z reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can we add a test that actually uses content type

@nopcoder
Copy link
Contributor Author

nopcoder commented Dec 8, 2023

the test calls the API with an empty content type like in the issue

@nopcoder nopcoder merged commit 17a5305 into master Dec 8, 2023
37 of 38 checks passed
@nopcoder nopcoder deleted the fix/upload-object-content-type branch December 8, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees

@nopcoder nopcoder

Labels
bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: objects_api.upload_object fails on temporary files
2 participants
@nopcoder @N-o-Z