Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Wrapper: Simple readline #7126

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Python Wrapper: Simple readline #7126

merged 2 commits into from
Dec 8, 2023

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Dec 7, 2023 •
edited
Loading

Closes #7066

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog python-wrapper labels Dec 7, 2023
@N-o-Z N-o-Z requested review from ozkatz and guy-har December 7, 2023 20:09
@N-o-Z N-o-Z self-assigned this Dec 7, 2023
guy-har
guy-har approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N-o-Z N-o-Z merged commit 79c5316 into master Dec 8, 2023
35 of 36 checks passed
@N-o-Z N-o-Z deleted the task/implement-readline-simple branch December 8, 2023 13:16
@guy-har guy-har mentioned this pull request Dec 10, 2023
Closed
@ozkatz
Copy link
Collaborator

ozkatz commented Dec 10, 2023

Would suggest taking a look at python's io.BufferedReader - it maintains the buffer for you as well as handles the scanning required for readline/readlines.

It could be made to natively wrap an ObjectReader by having it implement readinto.

@N-o-Z N-o-Z mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

@ozkatz ozkatz Awaiting requested review from ozkatz

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog python-wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Wrapper: support reader __iter__ for text files
3 participants
@N-o-Z @ozkatz @guy-har