Python Wrapper: Objects generator #7110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
exclude-changelog
N-o-Z
force-pushed
the
task/python-wrapper-objects-generator-7109
branch
from
17883de to
6dffbca
Compare
N-o-Z
force-pushed
the
task/python-wrapper-objects-generator-7109
branch
from
042814a to
ddb7746
Compare
guy-har
approved these changes
Dec 5, 2023
| @@ -9,6 +9,9 @@ | |||
|
|
|||
| from lakefs.namedtuple import LenientNamedTuple | |||
|
|
|||
| _PREFIX = "common_prefix" | |||
There was a problem hiding this comment.
I know it's not from this PR, but I prefer common_prefix, prefix has a different meaning
Suggested change
| _PREFIX = "common_prefix" | |
| _COMMON_PREFIX = "common_prefix" |
Comment on lines
+94
to
+99
| class CommonPrefix(LenientNamedTuple): | ||
| """ | ||
| Represents a common prefix in lakeFS | ||
| """ | ||
| path: str | ||
|
|
There was a problem hiding this comment.
Not sure if it's still wanted, but on the initial PRD CommonPrefix has an exists method
There was a problem hiding this comment.
For now, both ObjectInfo and CommonPrefix are data models and do not contain logic. For now it feels redundant providing them with functionality that is accessible via the branch / object level methods. Lets see if there's demand for that and add it as needed
| """ | ||
| Returns a ObjectManager object for this reference | ||
| Returns an object generator for this reference |
There was a problem hiding this comment.
object/common_prefix or find a better way to phrase it (even though the name of the method is objects)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7109
Change Description
Background
Implement object generator and separate ObjecStats into ObjectInfo, CommonPrefix
Testing Details
Unit and integration tests