Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Wrapper: Add skip workflow on required #7087

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Python Wrapper: Add skip workflow on required #7087

merged 2 commits into from
Dec 1, 2023

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Nov 30, 2023

Closes #7086

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog python-wrapper labels Nov 30, 2023
@N-o-Z N-o-Z self-assigned this Nov 30, 2023
@N-o-Z N-o-Z force-pushed the task/python-wrapper-required-workflow-7086 branch from e64a7d7 to e01f327 Compare November 30, 2023 11:07
@N-o-Z N-o-Z marked this pull request as ready for review November 30, 2023 11:08
@N-o-Z N-o-Z requested a review from nopcoder November 30, 2023 11:08
nopcoder
nopcoder suggested changes Nov 30, 2023
View reviewed changes
.github/workflows/python-wrapper-unit-tests.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we keep it one job? and make the step optional?
  2. Filter should consider changes in this python workflow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Making it a single job will require putting conditions on each and every step - I don't like this idea
  2. Done

@N-o-Z N-o-Z requested a review from nopcoder December 1, 2023 09:28
nopcoder
nopcoder approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@N-o-Z N-o-Z merged commit b720c98 into master Dec 1, 2023
34 checks passed
@N-o-Z N-o-Z deleted the task/python-wrapper-required-workflow-7086 branch December 1, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog python-wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Wrapper: Make unit test workflow required in project
2 participants
@N-o-Z @nopcoder