Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve iceberg docs #6820

Merged
merged 4 commits into from
Oct 22, 2023
Merged

improve iceberg docs #6820

merged 4 commits into from
Oct 22, 2023

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented Oct 19, 2023 •
edited
Loading

No description provided.

@johnnyaug johnnyaug added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 19, 2023
@johnnyaug johnnyaug requested a review from lynnro314 October 19, 2023 12:02
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

♻️ PR Preview 820ca70 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@johnnyaug johnnyaug requested a review from nopcoder October 22, 2023 10:34
nopcoder
nopcoder reviewed Oct 22, 2023
View reviewed changes
docs/integrations/iceberg.md Outdated
* Branch
* Tag
* Expression (for example, `main~17` means _17 commits before main_)
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell

nopcoder
nopcoder reviewed Oct 22, 2023
View reviewed changes
docs/integrations/iceberg.md Outdated

Here are some examples:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shell

nopcoder
nopcoder reviewed Oct 22, 2023
View reviewed changes
docs/integrations/iceberg.md Outdated
```python
.config("spark.sql.defaultCatalog", "lakefs") \
```
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing two spaces to indent

nopcoder
nopcoder approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments about the format

@johnnyaug johnnyaug merged commit 2b25c17 into master Oct 22, 2023
29 checks passed
@johnnyaug johnnyaug deleted the docs/improve_iceberg_docs branch October 22, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

@lynnro314 lynnro314 Awaiting requested review from lynnro314

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyaug @nopcoder