Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lakeFSFS ETag value when using pre-signed mode #6751

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix lakeFSFS ETag value when using pre-signed mode #6751

merged 1 commit into from
Oct 11, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 10, 2023 •
edited
Loading

Fix #6756

@nopcoder nopcoder added bug Something isn't working include-changelog PR description should be included in next release changelog area/client/hadoopfs labels Oct 10, 2023
@nopcoder nopcoder self-assigned this Oct 10, 2023
@nopcoder nopcoder requested a review from johnnyaug October 10, 2023 21:58
@johnnyaug
Copy link
Contributor

johnnyaug commented Oct 11, 2023 •
edited
Loading

LGTM - just test that Content-MD5 always returns as base64 from all cloud vendors.

@nopcoder
Copy link
Contributor Author

LGTM - just test that Content-MD5 always returns as base64 from all cloud vendors.

Verified that the above fix works for s3 and azure.
Based on the https://datatracker.ietf.org/doc/html/rfc1864 it is always base64.

@nopcoder nopcoder merged commit 54db640 into master Oct 11, 2023
33 of 37 checks passed
@nopcoder nopcoder deleted the fix/hadoopfs-azure-content-md5 branch October 11, 2023 09:35
@nopcoder nopcoder mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyaug johnnyaug johnnyaug approved these changes

Assignees

@nopcoder nopcoder

Labels
area/client/hadoopfs bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hadoop LakeFS library write entry's checksum as base64 instead of hex
2 participants
@nopcoder @johnnyaug