Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkPhysicalAddress trim quotes and spaces from checksum #6749

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 10, 2023

Close #6743

This should handle the case where a API provides checksum with " as part of Etag value as checksum.
As lakeFS holds this value without ", we strip them before we write the entry.

@nopcoder nopcoder added area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog labels Oct 10, 2023
@nopcoder nopcoder self-assigned this Oct 10, 2023
@nopcoder nopcoder changed the title LinkPhysicalAddress trim quotes and spaces from etag LinkPhysicalAddress trim quotes and spaces from checksum Oct 10, 2023
@nopcoder nopcoder requested a review from guy-har October 10, 2023 21:00
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder merged commit bbdefc3 into master Oct 11, 2023
@nopcoder nopcoder deleted the fix/link-address-trim-quotes branch October 11, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove double quotes from checksum on pre-signed upload
2 participants