Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link physical address response to contain full path #6748

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Oct 10, 2023

No description provided.

@guy-har guy-har added the include-changelog PR description should be included in next release changelog label Oct 10, 2023
@guy-har guy-har requested a review from nopcoder October 10, 2023 14:03
@guy-har guy-har marked this pull request as draft October 10, 2023 14:12
@guy-har guy-har removed the request for review from nopcoder October 10, 2023 14:13
@guy-har guy-har force-pushed the fix/link-physical-response branch 3 times, most recently from 0a5e4e3 to 0fd9b09 Compare October 11, 2023 12:53
@guy-har guy-har force-pushed the fix/link-physical-response branch from 0fd9b09 to 5e91912 Compare October 11, 2023 13:00
@guy-har guy-har marked this pull request as ready for review October 11, 2023 13:01
@guy-har guy-har requested a review from nopcoder October 11, 2023 13:06
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guy-har guy-har merged commit 386507b into master Oct 12, 2023
29 checks passed
@guy-har guy-har deleted the fix/link-physical-response branch October 12, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Physical address in upload response between pre-signed and not pre-signed
2 participants