Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metaclient: Drop Hadoop 2 support #6740

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Metaclient: Drop Hadoop 2 support #6740

merged 9 commits into from
Oct 10, 2023

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented Oct 9, 2023 •
edited
Loading

Resolves #6201.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

♻️ PR Preview bbbb70c has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@johnnyaug johnnyaug changed the title gen after merge Metaclient: Drop Hadoop 2 support Oct 9, 2023
@johnnyaug johnnyaug added the exclude-changelog PR description should not be included in next release changelog label Oct 9, 2023
@johnnyaug johnnyaug marked this pull request as ready for review October 9, 2023 13:27
@johnnyaug johnnyaug requested a review from nopcoder October 9, 2023 13:27
arielshaqed
arielshaqed approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted all my horrible build.sbt hacks! I will never again convince anyone that I am an 3133+ SBT h4xx0r!!

Thanks, this is truly lovely. spark/core/src/main/hadoop{2,3} are now empty, right?

nopcoder
nopcoder approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just question about isSnapshot

clients/spark/build.sbt Outdated
lazy val projectVersion = "0.10.0"
lazy val hadoopVersion = "3.2.1"

ThisBuild / isSnapshot := false
ThisBuild / isSnapshot := true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not expert on sbt - but do we need to mark this one always as true it is not set based on how we publish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just an experiment, good catch

@johnnyaug johnnyaug merged commit 9926364 into master Oct 10, 2023
30 checks passed
@johnnyaug johnnyaug deleted the metaclient/drop_old_hadoop_support branch October 10, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Hadoop2 support from Spark metadata client
3 participants
@johnnyaug @nopcoder @arielshaqed