Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: enable the links to the publish sdk packages for v1 #6732

Merged
merged 5 commits into from
Oct 10, 2023
Merged

docs: enable the links to the publish sdk packages for v1 #6732

merged 5 commits into from
Oct 10, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 8, 2023

No description provided.

@nopcoder nopcoder added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 8, 2023
@nopcoder nopcoder self-assigned this Oct 8, 2023
johnnyaug
johnnyaug approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

♻️ PR Preview 358ad7b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@nopcoder nopcoder enabled auto-merge (squash) October 8, 2023 17:29
@nopcoder nopcoder disabled auto-merge October 8, 2023 17:32
arielshaqed
arielshaqed approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact still no accessible on Maven Central. But it is accessible by using direct coordinates.

I say we pull and get it over with, it should show up eventually.

@arielshaqed
Copy link
Contributor

It's right there on https://mvnrepository.com/artifact/io.lakefs/sdk. Took a few hours longer than expected. ואף-על-פי שיתמהמה, בוא יבוא! And even as it might be delayed, it will surely come...

@nopcoder nopcoder enabled auto-merge (squash) October 10, 2023 07:58
@nopcoder
Copy link
Contributor Author

Switched to use https://search.maven.org/artifact/io.lakefs/sdk as the previous link returns 403 for the link checker (using HEAD I assume)

@nopcoder nopcoder merged commit 0e02042 into master Oct 10, 2023
@nopcoder nopcoder deleted the docs/sdk-links-back branch October 10, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@johnnyaug johnnyaug johnnyaug approved these changes

Assignees

@nopcoder nopcoder

Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nopcoder @arielshaqed @johnnyaug