Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Python lakefs-sdk publish workflow + add Gemfile #6731

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Enable Python lakefs-sdk publish workflow + add Gemfile #6731

merged 7 commits into from
Oct 8, 2023

Conversation

Jonathan-Rosenberg
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg commented Oct 8, 2023 •
edited
Loading

No description provided.

@Jonathan-Rosenberg Jonathan-Rosenberg added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 8, 2023
nopcoder
nopcoder suggested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about the missing gemfiles issue.
Also I think we should update the workflow to enable back the docs generation.

@Jonathan-Rosenberg Jonathan-Rosenberg changed the title Fix: Install ruby in the correct working directory Enable Python lakefs-sdk publish workflow + add Gemfile Oct 8, 2023
N-o-Z
N-o-Z requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix order: New sdk steps first, then legacy

N-o-Z
N-o-Z approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@N-o-Z N-o-Z enabled auto-merge (squash) October 8, 2023 16:50
@N-o-Z N-o-Z merged commit b3a2f7d into master Oct 8, 2023
31 checks passed
@N-o-Z N-o-Z deleted the fix/python-sdk/docs branch October 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@nopcoder nopcoder Awaiting requested review from nopcoder

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonathan-Rosenberg @nopcoder @N-o-Z