Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github workflows to use amazon-ecr-login v2 #6673

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update github workflows to use amazon-ecr-login v2 #6673

merged 2 commits into from
Oct 3, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Oct 2, 2023 •
edited
Loading

Fix mask password warning.

Example:

Test lakeFS Hadoop FileSystem compatibility (0.92.0)Your docker password is not masked. See https://github.com/aws-actions/amazon-ecr-login#docker-credentials for more information.

@nopcoder nopcoder self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@nopcoder nopcoder added infrastructure build, deploy and release processes exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 2, 2023
arielshaqed
arielshaqed approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC we didn't expose our password, just got a dummy warning, right? (Do we even pull with a password??)

@nopcoder
Copy link
Contributor Author

nopcoder commented Oct 2, 2023

IIUC we didn't expose our password, just got a dummy warning, right? (Do we even pull with a password??)

We just need to registry address. The new version set the default to mark true - so they just need to release it and we will be good.

@nopcoder nopcoder force-pushed the fix/github-ecr-creds branch from 8d23cb4 to 3a20fa2 Compare October 3, 2023 07:36
@nopcoder nopcoder merged commit 13da37d into master Oct 3, 2023
@nopcoder nopcoder deleted the fix/github-ecr-creds branch October 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
exclude-changelog PR description should not be included in next release changelog infrastructure build, deploy and release processes minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @arielshaqed