Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lakectl local verify bad path error on Windows #6602

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix lakectl local verify bad path error on Windows #6602

merged 1 commit into from
Sep 14, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 14, 2023 •
edited
Loading

Fix #6599

  • Fix use filepath.Join for target path verification
  • Sync start workers (goroutines) based on max parallelism instead of creating one for each file
  • Code style - not using named return value in apply and avoid format instead of string concatenation

@nopcoder nopcoder added bug Something isn't working area/lakectl Issues related to lakeFS' command line interface (lakectl) include-changelog PR description should be included in next release changelog labels Sep 14, 2023
@nopcoder nopcoder self-assigned this Sep 14, 2023
@nopcoder nopcoder requested review from arielshaqed and idanovo and removed request for arielshaqed September 14, 2023 07:32
idanovo
idanovo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@idanovo idanovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@nopcoder nopcoder merged commit 0b3302d into master Sep 14, 2023
@nopcoder nopcoder deleted the fix/ctl-local-win branch September 14, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanovo idanovo idanovo approved these changes

Assignees

@nopcoder nopcoder

Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: lakectl local clone doesn't work for windows
2 participants
@nopcoder @idanovo