Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a comment that destination of import should not start with '/' #6601

Closed
wants to merge 1 commit into from

Conversation

iddoavn
Copy link
Contributor

@iddoavn iddoavn commented Sep 13, 2023

Addresses #6600

Change Description

As a quick workaround, adding a comment to not accept an import that start with '/'. A better solution would be to not allow the code to accept it and present a suitable message.

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@nopcoder
Copy link
Contributor

nopcoder commented Oct 25, 2023

With the improved import dialog, thanks to @johnnyaug it is now clear the final import path for import. The Destination field starts with repository/branch/ (readonly) so it is very clear the user should not add extra '/'.

Can I close this issue? @iddoavn @ozkatz

image

Copy link

This PR is now marked as stale after 30 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Nov 25, 2023
Copy link

github-actions bot commented Dec 3, 2023

Closing this PR because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants