UI: Commit info consistent across screens #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkatz
added
area/UI
arielshaqed
reviewed
Sep 14, 2023
|
Really cool, seems great, and I reckon it is structured better this way. But will defer to @eladlachmi And The GUI Wizards on this. |
nopcoder
approved these changes
Sep 14, 2023
| <tr> | ||
| <td><strong>Creation Date</strong></td> | ||
| <td> | ||
| {dayjs.unix(commit.creation_date).format("MM/DD/YYYY HH:mm:ss")} ({dayjs.unix(commit.creation_date).fromNow()}) |
There was a problem hiding this comment.
I know this is not knew but we should use localized date/time formats.
There was a problem hiding this comment.
we should. Feel free to open an issue :)
|
Thanks @ozkatz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the commit information component to
src/lib/components/to make it reusable across screens.Used it to make both the commit page and the "blame" button in the objects page to show the same info in a consistent manner.
"Blame" Before:
"Blame" After: