Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UpdateBranchToken API #6590

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Remove UpdateBranchToken API #6590

merged 5 commits into from
Sep 19, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 12, 2023 •
edited
Loading

Close #5874
Close #6524

@nopcoder nopcoder added area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog labels Sep 12, 2023
@nopcoder nopcoder self-assigned this Sep 12, 2023
@nopcoder nopcoder changed the title Remove UpdateBranchToken API use and implementation Remove UpdateBranchToken API Sep 12, 2023
@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

♻️ PR Preview 9dff006 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

arielshaqed
arielshaqed approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good riddance, I guess.

Can't remember why we ever had it; I guess for one of the import implementations? We might need something like this for when we write lakectl stash, but it won't be this one and definitely not until we know what we need.

@nopcoder
Copy link
Contributor Author

Still not merging this one - import test on azure fails without calling upgrade branch token

@nopcoder nopcoder force-pushed the chore/upd-branch-token branch from c9573d7 to 9e5b4f0 Compare September 17, 2023 12:46
itaiad200
itaiad200 previously requested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing this deleted and just making sure no flow breaks

@nopcoder
Copy link
Contributor Author

Not seeing this deleted and just making sure no flow breaks

Thanks, blocked from merge this change as it looks like Azure ingest flow depends on this logic.
The code you referenced is not in used and we can remove it from the webui.
I was thinking on removing all the ingest API but I wasn't sure if there is still code that would like to use it.

@nopcoder
remove updateToken from webui api
6dba8cd
@nopcoder
API cleanup: remove IngestRange and CreateMetaRange APIs (#6610)
21c9498 
* Fix ui pkg update and unused code (#6608)

* Remove create metadata and ingest range APIs

* use different branches for copy tests
@nopcoder
Merge branch 'master' into chore/upd-branch-token
9dff006
@itaiad200 itaiad200 dismissed their stale review September 19, 2023 12:36

Unblocking, can't review

@nopcoder nopcoder merged commit 772649d into master Sep 19, 2023
34 checks passed
@nopcoder nopcoder deleted the chore/upd-branch-token branch September 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@itaiad200 itaiad200 itaiad200 left review comments

Assignees

@nopcoder nopcoder

Labels
area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API cleanup: updateBranchToken Import: Deprecate plumbing API
3 participants
@nopcoder @arielshaqed @itaiad200