Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest version cache and remove the use of go-github #6572

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix latest version cache and remove the use of go-github #6572

merged 1 commit into from
Sep 10, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 9, 2023

  • Fetch lakefs latest release from github without using go-github. It will reduce the binary size of both lakefs and lakectl
  • Refactor version template
  • Fix refresh cache internal and set the default to 1h

Fix #6571

@nopcoder
Remove the use of go-github 3rd party lib
c595dba 
- Fetch lakefs latest release from github without using go-github.
  It will reduce the binary size of both lakefs and lakectl
- Refactor version template
- Fix refresh cache internal and set the default to 1h
@nopcoder nopcoder requested a review from Isan-Rivkin September 9, 2023 20:54
@nopcoder nopcoder self-assigned this Sep 9, 2023
@nopcoder nopcoder added bug Something isn't working include-changelog PR description should be included in next release changelog labels Sep 9, 2023
@nopcoder nopcoder changed the title Remove the use of go-github 3rd party lib Fix latest version cahce and remove the use of go-github Sep 9, 2023
@nopcoder nopcoder added improvement refactor Code refactoring that improves the code but does not affect functionality labels Sep 9, 2023
@nopcoder nopcoder changed the title Fix latest version cahce and remove the use of go-github Fix latest version cache and remove the use of go-github Sep 10, 2023
Isan-Rivkin
Isan-Rivkin approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nopcoder nopcoder merged commit d9d76dd into master Sep 10, 2023
42 of 44 checks passed
@nopcoder nopcoder deleted the chore/go-github branch September 10, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isan-Rivkin Isan-Rivkin Isan-Rivkin approved these changes

Assignees

@nopcoder nopcoder

Labels
bug Something isn't working improvement include-changelog PR description should be included in next release changelog refactor Code refactoring that improves the code but does not affect functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The configuration check_latest_version_cache configuration is not in use
2 participants
@nopcoder @Isan-Rivkin