Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lakectl: deprecate dbt and metastore commands #6565

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 7, 2023

All lakectl dbt and metastore command will print deprecation warnings.

Close #6564

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Sep 7, 2023
@nopcoder nopcoder requested a review from itaiad200 September 7, 2023 16:08
@itaiad200
Copy link
Contributor

I think that the integration pages should help clarify the current situation: These command are deprecated and would be removed soon. A better, automated integration will replace them.

Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder requested a review from itaiad200 September 10, 2023 21:10
@nopcoder
Copy link
Contributor Author

@itaiad200 please review the documentation changes

@github-actions
Copy link

github-actions bot commented Sep 10, 2023

♻️ PR Preview 1c5d301 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@nopcoder nopcoder requested a review from itaiad200 September 11, 2023 07:54
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder enabled auto-merge (squash) September 11, 2023 08:09
@nopcoder nopcoder merged commit abf880a into master Sep 11, 2023
33 checks passed
@nopcoder nopcoder deleted the chore/lakectl-deprecate-cmds branch September 11, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API cleanup: mark lakectl deprecated functionality
2 participants