got the region

treeverse · Dec 24, 2024 · d9a5387 · d9a5387
1 parent 1692af8
commit d9a5387
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/block/s3/client_cache.go b/pkg/block/s3/client_cache.go
@@ -142,7 +142,7 @@ func (c *ClientCache) cachedClientByRegion(region string) (*s3.Client, bool) {
 
 func (c *ClientCache) refreshBucketRegion(ctx context.Context, bucket string) string {
 	region, err := c.s3RegionGetter(ctx, bucket)
-	if err != nil {
+	if err != nil || region == "" {
 		// fallback to default region
 		region = c.awsConfig.Region
 		logging.FromContext(ctx).