Skip to content

Commit

Permalink
prep for merge
Browse files Browse the repository at this point in the history
  • Loading branch information
Isan-Rivkin committed Oct 19, 2023
1 parent b35911f commit 14b4ac2
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions esti/catalog_export_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,10 @@ func TestAWSCatalogExport(t *testing.T) {
requireBlockstoreType(t, block.BlockstoreTypeS3)
// skip of the following args are not provided
accessKeyID := viper.GetString("aws_access_key_id")
secretKeyID := viper.GetString("aws_secret_access_key")
secretAccessKey := viper.GetString("aws_secret_access_key")
glueDB := viper.GetString("glue_export_hooks_database")
glueRegion := viper.GetString("glue_export_region")
requiredArgs := []string{accessKeyID, secretKeyID, glueDB, glueRegion}
requiredArgs := []string{accessKeyID, secretAccessKey, glueDB, glueRegion}
if slices.Contains(requiredArgs, "") {
t.Skip("One of the required Args empty")
}
Expand All @@ -264,9 +264,9 @@ func TestAWSCatalogExport(t *testing.T) {
GlueActionPath: "_lakefs_actions/glue_export.yaml",
TableDescriptorPath: "_lakefs_tables/animals.yaml",
GlueDB: glueDB,
Region: glueDB,
Region: glueRegion,
AccessKeyId: accessKeyID,
SecretAccessKey: secretKeyID,
SecretAccessKey: secretAccessKey,
TableSpec: &hiveTableSpec{
Name: "animals",
Type: "hive",
Expand Down Expand Up @@ -374,6 +374,5 @@ func TestAWSCatalogExport(t *testing.T) {
require.Equal(t, "org.apache.hadoop.hive.ql.io.SymlinkTextInputFormat", aws.ToString(glueTable.StorageDescriptor.InputFormat), "wrong table input format")
require.Equal(t, "org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat", aws.ToString(glueTable.StorageDescriptor.OutputFormat), "wrong table output format")
require.Equal(t, symlinkPrefix, aws.ToString(glueTable.StorageDescriptor.Location)+"/", "wrong s3 location in glue table")
require.Equal(t, "matilda", *glueTable.Name, "oopsie")
})
}

0 comments on commit 14b4ac2

Please sign in to comment.