CF Fixes

treeverse · Dec 5, 2023 · 13869e6 · 13869e6
1 parent 448674d
commit 13869e6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/clients/python-wrapper/lakefs/import_manager.py b/clients/python-wrapper/lakefs/import_manager.py
@@ -10,7 +10,7 @@
 
 import lakefs_sdk
 
-from lakefs.models import ImportStatus, _OBJECT, _PREFIX
+from lakefs.models import ImportStatus, _OBJECT, _COMMON_PREFIX
 from lakefs.client import Client, DEFAULT_CLIENT
 from lakefs.exceptions import ImportManagerException, api_exception_handler
 
@@ -54,7 +54,8 @@ def prefix(self, object_store_uri: str, destination: str) -> ImportManager:
         :param destination: The destination prefix relative to the branch
         :return: The ImportManager instance (self) after update, to allow operations chaining
         """
-        self.sources.append(lakefs_sdk.ImportLocation(type=_PREFIX, path=object_store_uri, destination=destination))
+        self.sources.append(
+            lakefs_sdk.ImportLocation(type=_COMMON_PREFIX, path=object_store_uri, destination=destination))
         return self
 
     def object(self, object_store_uri: str, destination: str) -> ImportManager:

diff --git a/clients/python-wrapper/lakefs/models.py b/clients/python-wrapper/lakefs/models.py
@@ -9,7 +9,7 @@
 
 from lakefs.namedtuple import LenientNamedTuple
 
-_PREFIX = "common_prefix"
+_COMMON_PREFIX = "common_prefix"
 _OBJECT = "object"
 
 

diff --git a/clients/python-wrapper/lakefs/reference.py b/clients/python-wrapper/lakefs/reference.py
@@ -49,7 +49,8 @@ def objects(self,
                 delimiter: Optional[str] = None,
                 **kwargs) -> Generator[StoredObject | CommonPrefix]:
         """
-        Returns an object generator for this reference
+        Returns an object generator for this reference, the generator can yield either a StoredObject or a CommonPrefix
+        object depending on the listing parameters provided.
 
         :param max_amount: Stop showing changes after this amount
         :param after: Return items after this value