Make sure sending cancel request in StatementClient.close #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make sure sending cancel request in
StatementClient.close()
Overview
StatementClient.close()
sends a cancel request:trino-client-ruby/lib/trino/client/statement_client.rb
Lines 264 to 280 in 55c3bdc
But it doesn't if any errors happen inside the client because
state
is changed toclient_error
inexception!()
:trino-client-ruby/lib/trino/client/statement_client.rb
Lines 133 to 136 in 55c3bdc
This change will make sure sending a cancel request when
StatementClient.close()
is called unlessstate
isfinished
,query_failed
orclient_abort
.Checklist