Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace duration with elapsed_time in Slack Notifications #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jacobkg
Copy link
Contributor

@Jacobkg Jacobkg commented Apr 8, 2016

This is probably controversial, but I would argue better in almost all cases

See, e.g travis-ci/travis-ci#5811

@BanzaiMan

@joshk
Copy link
Contributor

joshk commented Apr 8, 2016

Ohhhhhh I'm torn on this. It makes sense and could be a good change, but
then maybe we should do it everywhere?

Also, we have found a small bug with elapsed time and should maybe wait
until that is fixed.

On Fri, 8 Apr 2016 at 5:12 PM, Josh Kalderimis [email protected]
wrote:

I
On Fri, 8 Apr 2016 at 5:10 PM, Jacob Green [email protected]
wrote:

This is probably controversial, but I would argue this is better.

See, e.g travis-ci/travis-ci#5811
travis-ci/travis-ci#5811

@BanzaiMan https://github.com/BanzaiMan

You can view, comment on, or merge this pull request online at:

#57
Commit Summary

  • Elapsed time is arguably more useful
  • Merge remote-tracking branch 'travis-ci/master'

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#57

@Jacobkg
Copy link
Contributor Author

Jacobkg commented Apr 8, 2016

@joshk What's the bug?

@Jacobkg
Copy link
Contributor Author

Jacobkg commented Apr 19, 2016

@joshk @BanzaiMan Any followup on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants