Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and tests #84

Merged
merged 25 commits into from
Dec 10, 2023
Merged

Update CI and tests #84

merged 25 commits into from
Dec 10, 2023

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Dec 10, 2023

Various housekeeping changes:

  • Adjust code to satisfy mypy with latest version and dependencies.
  • Update "pytest" CI workflow:
    • Split the "diagnostics" to a separate job.
    • Add a code quality/pre-commit job.
    • Update third-party actions.
    • Run on all 3 supported operating systems and Python up to 3.12.
  • Convert packaging from setup.{cfg,py} to pyproject.toml.
  • Use ruff and mypy via pre-commit for code quality checks.
  • Adjust for "Turkey" no longer appearing in the ISO 3166 database.
  • Xfail certain tests: in particular, those using data via OpenKAPSARC that are no longer available because the provider has removed them.

@khaeru khaeru added the ci Continuous testing, integration, & other automation label Dec 10, 2023
@khaeru khaeru self-assigned this Dec 10, 2023
The source has removed the data flows used in the test.
The model can cause unintended side-effects when imported.
Add missing Jinja2 to dependencies.
- Update first- and third-party actions:
  - actions/checkout v2 → v3
  - actions/setup-python v2 → v4
  - codecov/codecov-action v1 → v3
- Use built-in concurrency instead of styfle/cancel-workflow-action.
- Don't install editable for testing.
- Don't update "wheel".
- Test on macos.
- Test on Python 3.8 through 3.12.
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c92baa3) 73.12% compared to head (40e254a) 73.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   73.12%   73.20%   +0.07%     
==========================================
  Files          34       42       +8     
  Lines        1388     1601     +213     
==========================================
+ Hits         1015     1172     +157     
- Misses        373      429      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khaeru khaeru merged commit 68f9fe0 into main Dec 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous testing, integration, & other automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant