Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show latest slowzone values #886

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Show latest slowzone values #886

merged 2 commits into from
Oct 30, 2023

Conversation

devinmatte
Copy link
Member

@devinmatte devinmatte commented Oct 30, 2023

Motivation

We have access to both the average and the latest slowzone values, we should show both, and the map should prioritize latest when showing today

Changes

Screenshot 2023-10-30 at 4 14 01 PM

Screenshot 2023-10-30 at 3 51 28 PM

Testing Instructions

@github-actions github-actions bot added the frontend Change to frontend code label Oct 30, 2023
@nathan-weinberg
Copy link
Member

nit: should latest be current?

@devinmatte
Copy link
Member Author

@nathan-weinberg The field exists in slowzones that have since ended. It shows the last slow speed before the slowzone was lifted/resolved, so it's latest for all except the ongoing slowzones

Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix for this issue, lgtm!

@github-actions github-actions bot added the dependencies Changes to dependencies label Oct 30, 2023
@devinmatte devinmatte merged commit 8e40926 into main Oct 30, 2023
5 checks passed
@devinmatte devinmatte deleted the slowzones/show-latest-value branch October 30, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to dependencies frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants