-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate NTT to Chalice from flask/ec2 #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to have this running on the same stuff as our other stuff! Chalice (and its cron decorators) seems like a good fit for the last-seen functionality in particular.
I haven't given this a line-by-line review but if it's working then I say ship it.
aria-label={line.name + ' line'} | ||
className="icon" | ||
style={{ backgroundColor: line.color }} | ||
<TabProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does adding TabProvider
do, out of curiosity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's required to store the state in the new version of the library (uses react hook state instead of older state.
Motivation
NTT currently costs a decent amount per month to run, Chalice would make it near free
It should also fix
Changes
Testing Instructions
Visit beta